Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out static checks for TypeScript/Next.js portion of the app #23

Merged
merged 15 commits into from
Apr 29, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Apr 25, 2024

PR Type

Feature

Short Description

Clickup Ticket(s): https://app.clickup.com/t/86879c71k

First of all, ignore all changes under florist/app, they are all style changes.

In this PR, I'm setting up:

  • next lint for catching JS errors, and adding it to the pre-commit hook and static code checks github action.
  • prettier for UI code format, and adding it to the pre-commit hook and static code checks github action
  • jest for testing, and adding it to the unit test github action
  • Adding one sample unit test for page.tsx
  • Adding instructions on how to run front-end tests
  • Adding autofix commit bots as per Enable pre-commit ci and add default config aieng-template#10
  • Adding unit test runs in pre-commit hooks
  • Deleting package-lock.json, we don't need it since we use yarn and it has yarn-lock.json.

Tests Added

florist/tests/app/page.text.tsx

@lotif lotif marked this pull request as ready for review April 25, 2024 21:04
@lotif lotif requested review from jewelltaylor and emersodb April 25, 2024 22:32
@lotif lotif mentioned this pull request Apr 25, 2024
Copy link
Contributor

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great to me! Everything runs locally on my machine too. Thanks for adding an example UI test, it will be helpful for me to add to the list-job-page PR :)

@lotif lotif merged commit 5252cb3 into main Apr 29, 2024
4 checks passed
@lotif lotif deleted the ts-lint branch April 29, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants